-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Windows CI (Appveyor) #84
Enable Windows CI (Appveyor) #84
Conversation
@rosenhouse I get an access denied when I click on the detail link above. Maybe need to open up perms on appveyor a bit so that folks can debug build failures? |
@rakelkar I accidentally enabled the appveyor integration on this repo, but I've removed it now. to see the appveyor build output for the branch on this PR, click the link I included in my original issue description. |
… On Nov 1, 2017 11:21 AM, "Gabe Rosenhouse" ***@***.***> wrote:
Hmm, we seem to be in a chicken & egg scenario here. Host local is
breaking on windows here, and you have #77
<#77> to make it work
on Windows, which I've said is blocked on this.
One option is to continue adding build-tags here. And then later rebase
#77 <#77> on top of
master?
Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADQphf3dqaVO6v5UAjjJdrSu3J2uThmpks5syLaugaJpZM4QNyPf>
.
|
8f8fb40
to
1ade2c2
Compare
ok @rakelkar, @containernetworking/cni-maintainers this is now green on:
Please take a look! Plan for post-merge:
|
LGTM. |
- start list of linux_only plugins; ignore them when testing on Windows - Isolate linux-only code by filename suffix - Remove stub (NotImplemented) functions - other misc. fixes for Windows compatibility
1ade2c2
to
99f6be0
Compare
@@ -1,3 +1,4 @@ | |||
// +build !windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+build !windows [](start = 3, length = 15)
what made you include this instead of renaming it to lock_linux.go like you did with the other files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this way the host-local
tests can run on my Mac :-)
LGTM |
Work in progress.DONE!Windows test output here